SHS-5661: Remove legacy fields #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SHS-5661--remove-legacy-fields
cienvaras
approved these changes
Jul 24, 2024
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
Jul 29, 2024
* SHS-5661: Remove legacy fields (#1577) * feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box * feat(SHS-5661): Remove other references to the overlay field * feat(SHS-5661): Add update hook to remove legacy field * fix(SHS-5661): Fix linting error * fix(shs-5661): remove hero-text-overlay variants and update viewmode config * SHS-4929: Hide caption/credits on images in default views (#1578) * feat(shs-4929): add new media view mode and update news default views * feat(shs-4929): update people default views * feat(shs-4929): update publications default views * SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579) * feat(SHS-5675): Add default table header rows to new tables in CKEditor * fix(SHS-5675): Fix linting error * docs(SHS-5675): Add comments describing change and source of change. * feat(SHS-5675): Update table heading color in CKEditor * fix(shs-5675): change color variable for table headings * fix(shs-5696): make normal the font style of blockquotes in wysiwyg (#1582) * SHS-5693: Implementation: New Vertical Card option (#1581) * feat(shs-5693): add view mode and and pattern for vertical button card * feat(shs-5693): configure the Style field to use the new view mode with the right label. * feat(shs-5693): add pattern into module preprocess function and update twig file * feat(shs-5693): more implementations in vertical button card * feat(shs-5693): implementations in vertical button card for colorful * feat(shs-5693): update box shadow * feat(shs-5693): update image position for colorful * feat(shs-5953): use secondary button styles in traditional and fix space in colorful when there's no image * fix(shs-5693): fix incorrect background color
cienvaras
added a commit
that referenced
this pull request
Aug 9, 2024
* feat(SHS-5629): Add patch to allow editing of media items in a modal from a node edit page * fix(SHS-5629): Remove todo in patch file * SHS-5661: Remove legacy fields (#1577) * feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box * feat(SHS-5661): Remove other references to the overlay field * feat(SHS-5661): Add update hook to remove legacy field * fix(SHS-5661): Fix linting error * fix(shs-5661): remove hero-text-overlay variants and update viewmode config --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-4929: Hide caption/credits on images in default views (#1578) * feat(shs-4929): add new media view mode and update news default views * feat(shs-4929): update people default views * feat(shs-4929): update publications default views --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * refactor(SHS-5629): Switch local patch for remote patch, add patch to fix missing save button on media modal * SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579) * feat(SHS-5675): Add default table header rows to new tables in CKEditor * fix(SHS-5675): Fix linting error * docs(SHS-5675): Add comments describing change and source of change. * feat(SHS-5675): Update table heading color in CKEditor * fix(shs-5675): change color variable for table headings --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * fix(shs-5629): revert composer.lock changes * fix(SHS-5629): Possible fix for dialog box too low on screen * fix(SHS-5629): Fix dialog too low on screen issue (clear browser cache to fix) * fix(shs-5629): remove unnecesary change * fix(shs-5629): update patch --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com> Co-authored-by: Mari Nez <mariannuar@gmail.com>
joegl
pushed a commit
that referenced
this pull request
Aug 13, 2024
* SHS-5692: Implementation: New Spotlight design for Colorful and Traditional (#1589) * SHS-5772: Regression: External Links on Postcards are wrong color (#1591) * SHS-5629: Editors can more easily edit a caption (#1580) * SHS-5661: Remove legacy fields (#1577) * SHS-4929: Hide caption/credits on images in default views (#1578) * SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579)
cienvaras
added a commit
that referenced
this pull request
Aug 22, 2024
* SHS-5692: Implementation: New Spotlight design for Colorful and Traditional (#1589) * feat(shs-5692): add new field for variantion style and start implementing new styles * feat(shs-5692): styles for colorful * feat(shs-5692): finish styles for colorful * feat(shs-5692): finish styles for colorful * feat(shs-5692): finish styles for traditional * feat(shs-5692): finish styles for traditional * fix(shs-5692): fix on colorful * fix(shs-5692): image dimensions and height when spotlits are in sliders * fix(shs-5692): refactor spotlight style field class assignation --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-5772 - Regression: External Links on Postcards are wrong color (#1591) * fix(shs-5772): regression in external links in postcards * fix(shs-5772): update card title link styles --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-5629: Editors can more easily edit a caption (#1580) * feat(SHS-5629): Add patch to allow editing of media items in a modal from a node edit page * fix(SHS-5629): Remove todo in patch file * SHS-5661: Remove legacy fields (#1577) * feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box * feat(SHS-5661): Remove other references to the overlay field * feat(SHS-5661): Add update hook to remove legacy field * fix(SHS-5661): Fix linting error * fix(shs-5661): remove hero-text-overlay variants and update viewmode config --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-4929: Hide caption/credits on images in default views (#1578) * feat(shs-4929): add new media view mode and update news default views * feat(shs-4929): update people default views * feat(shs-4929): update publications default views --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * refactor(SHS-5629): Switch local patch for remote patch, add patch to fix missing save button on media modal * SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579) * feat(SHS-5675): Add default table header rows to new tables in CKEditor * fix(SHS-5675): Fix linting error * docs(SHS-5675): Add comments describing change and source of change. * feat(SHS-5675): Update table heading color in CKEditor * fix(shs-5675): change color variable for table headings --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * fix(shs-5629): revert composer.lock changes * fix(SHS-5629): Possible fix for dialog box too low on screen * fix(SHS-5629): Fix dialog too low on screen issue (clear browser cache to fix) * fix(shs-5629): remove unnecesary change * fix(shs-5629): update patch --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com> Co-authored-by: Mari Nez <mariannuar@gmail.com> * feat(shs-5691): add new color pallete-for-traditional * feat(shs-5691): add new color palette-for-traditional * fix(shs-5691): update secondary and secondary active colors --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: Marc Berger <107938318+codechefmarc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
field_hs_hero_overlay_color) from the Banner image with full overlay and text paragraph.Need Review By (Date)
7/22/2024
Urgency
low
Steps to Test
admin/structure/paragraphs_type/hs_hero_image/fieldsand verify that there is no longer an "Overlay Color" field.PR Checklist